1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/upload.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Nov 11 19:03:53 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/7ff0e5c882f0159ed7c2d9a7
    Modified Files:
    src/sbbs3/upload.cpp
    Log Message:
    Fix sbbsfile.nam contents: contained file's description instead of name

    Found during review of previous commit.
    Introduced as part of the new file base branch merge (commit fcf58640).

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Jan 31 18:37:57 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/099c5fa5f8a810cc8721ba6e
    Modified Files:
    src/sbbs3/upload.cpp
    Log Message:
    Fix "Testable Files" file extension comparison

    Issue introduced in v3.19: Testable Files (a.k.a. upload processors) with a specified file extension/type (e.g. "ZIP" and not "*") would never run because the file extension comparison logic was "off by one". Testable Files with an extension of "*" (all files/types) would still run however.

    This fixes issue #331 reported by Nightfox.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Feb 23 00:19:23 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/baccf391632add816547ecce
    Modified Files:
    src/sbbs3/upload.cpp
    Log Message:
    Fix issue with blind/batch uploaded file descriptions

    When no file description was provided (e.g. blind/batch file uploads), I noticed that the short file description (summary) could be set to "(null)". This problem was introduced in commit bc7030d33b264058c4 with the sbbsfile.des creation and post-processing support.

    I also noticed that the extended description processing in sbbs_t::uploadfile() was not entirely consistent with other methods of adding/uploading files. Let prep_file_desc() do its just of processing the extended description into a suitable short description/summary (including truncation).

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Mar 13 23:33:54 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/c524eca2e9f3b2653f2fb95d
    Modified Files:
    src/sbbs3/upload.cpp
    Log Message:
    Use new Hashing/HashedFile text.dat strings, better > 4GB file support

    Resolve issues displaying file sizes > 4GB and calculating credit values.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Mar 13 23:39:14 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/f9fe854e06f6bb16ed9b5662
    Modified Files:
    src/sbbs3/upload.cpp
    Log Message:
    Fix issues with std::min() again...

    std::min() requires both arguments be of same type too.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Mar 13 23:43:25 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/0c9985d428ca75bbf46fb1fa
    Modified Files:
    src/sbbs3/upload.cpp
    Log Message:
    MSVC didn't like that use of std::min(), so just go back to a macro

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (in GitKraken)@VERT to Git commit to main/sbbs/master on Fri Mar 3 17:45:11 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/7d5a43c21a817b9db73988ff
    Modified Files:
    src/sbbs3/upload.cpp
    Log Message:
    Since protocol() now calculates elapsed time, use that

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Aug 1 15:25:45 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/39f65ac365e7212a9ec30ef2
    Modified Files:
    src/sbbs3/upload.cpp
    Log Message:
    Send notification messages to recipients of files sent via Terminal server

    Using the UserSentYouFile text.dat string

    user-to-user file transfers used to do this, but that was lost during the newfilebase refactor (originally removed the user-to-user xfer feature altogether, but then restored it, but without the notification feature) - so that text.dat string has gone unused for years now.

    Uploads to the sysop directory will notify the sysop using the full notification scheme, which includes an email notification. This may be an
    "over notification", but let's see how sysops (i.e. Nelgin) like it.

    This doesn't do anything about notifying recipients of files uploaded via
    other means (e.g. FTP).

    Fixes issue #955

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net