1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/load_cfg.c

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Jan 21 01:44:24 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9439f5b8e23351f3a96982b0
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix: initialize default data directories after auto-creating sub-dirs

    When a file library's "Access to Sub-directories" option was enabled, any auto-created directories would have their data dir initialized as "blank" (empty), so their data files (e.g. <code>.dat, <code>.ixb) would be created in the ctrl directory.

    I guess nobody used this feature? It is pretty cool, but not really documented. If you were using it before this commit, you'll need to move your sub-directories data files to data/dirs or re-add the files (recreate the database files). And you can remove the old cruft from the ctrl dir.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Ragnarok@VERT/DOCKSUD to Rob Swindell on Thu Jan 21 13:51:51 2021
    El 21/1/21 a las 06:44, Rob Swindell escribió:
    https://gitlab.synchro.net/main/sbbs/-/commit/9439f5b8e23351f3a96982b0 Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix: initialize default data directories after auto-creating sub-dirs

    When a file library's "Access to Sub-directories" option was enabled, any auto-created directories would have their data dir initialized as "blank" (empty), so their data files (e.g. <code>.dat, <code>.ixb) would be created in the ctrl directory.

    I guess nobody used this feature? It is pretty cool, but not really documented. If you were using it before this commit, you'll need to move your sub-directories data files to data/dirs or re-add the files (recreate the database files). And you can remove the old cruft from the ctrl dir.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net


    Coincidentally, a few weeks ago I found that option and could not find
    any documentation for it.

    When you have some free time, can you add some documentation please?

    Thank you!

    ---
    ￭ Synchronet ￭ Dock Sud BBS TLD 24 HS - bbs.docksud.com.ar
  • From Digital Man@VERT to Ragnarok on Thu Jan 21 12:21:15 2021
    Re: Re: src/sbbs3/load_cfg.c
    By: Ragnarok to Rob Swindell on Thu Jan 21 2021 01:51 pm

    When you have some free time, can you add some documentation please?

    Yup, plan to.
    --
    digital man

    Rush quote #31:
    Live for yourself, there's no one else more worth living for
    Norco, CA WX: 67.9°F, 43.0% humidity, 7 mph NE wind, 0.00 inches rain/24hrs
    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon Sep 25 16:36:18 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/566c41b6ab3cbbe97fc25009
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Allow text strings to be identified by number (instead of ID)

    for those that want to use cryptic numbers rather than human-readable names.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon Sep 25 17:39:43 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b44b6ea733cd12a51560b980
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix off-by-one issue in previous commit, text.dat string numbers are 1-based

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Dec 18 21:48:11 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/4197ced7afc511120e8d284b
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix new crash on startup for Windows build

    load_cfg() calls free_cfg() before do_cryptInit() is called, so the ssl_rwlock was uninitialized here.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Dec 18 21:51:09 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/c15b7a2f57ccf21ad44f7e3c
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix new clang warning: incompatible pointer types passing 'long *' to parameter of type 'int *'

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue Dec 19 01:29:23 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/587eca57b14dc020487c22d8
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    We don't need to set tls_certificate to -1 in prep_cfg() because
    it's only called from load_cfg() which has already set it to -1.

    We also don't need to check prepped twice to make sure it's extra true.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Dec 19 01:31:01 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d47a2258d7f870e139cdf0b4
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Always set scfg.prepped to FALSE in free_cfg()

    Remove some redundant redundancies, redundantly

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Jan 23 12:17:37 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/0503c2900a17ddd91986b312
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix uninitialized cfg.colors[] element usage caught by Deuce (and Clang?)

    Conditional jump or move depends on uninitialised value(s)
    at 0x4AE768D: sbbs_t::backfill(char const*, float, int, int) (con_out.cpp:1445)
    by 0x4AE7855: sbbs_t::progress(char const*, int, int, int) (con_out.cpp:1467)
    by 0x4AE91A9: ProgressLoadingMsgPtrs(void*, int, int) (data_ovl.cpp:27)
    by 0x4C7C577: getmsgptrs (userdat.c:3972)
    by 0x4AE9144: sbbs_t::getmsgptrs() (data_ovl.cpp:39)
    by 0x4BF9237: sbbs_t::logon() (logon.cpp:452)
    by 0x4AC1CE2: sbbs_t::answer() (answer.cpp:636)
    by 0x4C0FD37: node_thread(void*) (main.cpp:4277)

    Introduced in commit 48e7520e (when colors was converted from a byte array
    to a uint array), we weren't memsetting the right number of bytes.

    Since color is not an array of ints (not bytes), memset (of non-zero values) isn't really the right initialization approach anyway. Now using a for-loop.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Jun 21 00:26:42 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/26920170a050ba2300ecebc7
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix small memory leak when loading lib "Auto-Add Subs" feature enabled

    caught by valgrind

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Dec 6 17:38:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/a4dea66efb569f5681913d56
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Check return value of smb_create() in smb_open_dir()

    Resolves CID 515657

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Jan 15 20:09:08 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/a35294c13c0056b163095beb
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Remove dead code, fixing CID 530828

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on macOS)@VERT to Git commit to main/sbbs/master on Sun Mar 9 22:57:35 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/7e1189ca981b16ec9335c84e
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Don't try to load node.ini if no nodes are configured in main.ini

    But set the error string to hopefully be printed as a warning

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Mar 27 18:50:18 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/f09df78e24809b7eb797cac7
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Better range checking of the configure node paths

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Apr 2 22:58:19 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/e47530ffd0e039fb304806b5
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    sys_timezone() no longer modifies the scfg_t.sys_timezone member itself

    ... just the returned copy (when toggling the DST flag).

    This resolve the issue of SCFG->System menu detecting changes by the sysop
    (and prompting to Save Changes when exiting) when no changes were actually made, just that DST had been auto-enabled/disabled based on the date.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Aug 8 14:00:10 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/4835f32f2d219721d0c94bf3
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    De-duplicate dir internal codes when using a file lib's "Auto-Add Sub-dirs"

    ... feature, combined with manually created directories.

    This should fix the reported chksetup.js error reported in IRC:
    <Finglonger> Duplicate file directory internal code in fido: FIDO_DAILYLIST

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Aug 8 15:12:18 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/4c77244820e7cd40b30417cc
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Update to previous commit (which didn't fix reported issue)

    The trailing slash on the sub-directory name was still part of the string
    being compared (e.g. to internal codes), so that wasn't going to fix it.
    Kind of refactored this since it was removing and re-adding and then removing the trailing the slash again. And we didn't need to write the dir.code here since that's written in the loop that follows.

    This should fix the issue that finglonger reported on IRC.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net